Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random test TestDirectoryTaxonomyReader#testGetPathAndOrdinalsRandomMultithreading #12790

Merged
merged 1 commit into from Nov 9, 2023

Conversation

epotyom
Copy link
Contributor

@epotyom epotyom commented Nov 9, 2023

Fix bug from #12769

Copy link
Member

@mikemccand mikemccand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @epotyom -- gradlew check passes on my dev box -- I'll merge without waiting for the GH actions.

@mikemccand mikemccand merged commit e1af418 into apache:main Nov 9, 2023
4 checks passed
@epotyom epotyom changed the title Fix random test TestDirectoryTaxonomyReader#TestDirectoryTaxonomyReader Fix random test TestDirectoryTaxonomyReader#testGetPathAndOrdinalsRandomMultithreading Nov 9, 2023
@epotyom
Copy link
Contributor Author

epotyom commented Nov 9, 2023

I've re-run the tests multiple times just in case, there were no errors:

./gradlew -p lucene/facet test --tests "*TestDirectoryTaxonomyReader*"  -Ptests.iters=1000
...
:lucene:facet:test (SUCCESS): 16000 test(s)

@uschindler
Copy link
Contributor

I need to merge this also into the java 22 mmap branch where Jenkins runs on. #12706

@uschindler
Copy link
Contributor

OK merged to java 22 branch. Tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants