Adding HumanReadableQuery with a descrition param, used for debugging print output

[slow-J]

We use this only in KnnByte/FloatVectorQuery toString method so the benchmarker can disambiguate between different KnnFloatVectorQuery/KnnByteVectorQuery queries.

Closes #12487 and should enable VectorQuery fixes to the benchmarker in mikemccand/luceneutil#226. More details about the problem in the issues.

[jpountz]

I'd rather like not to touch these queries, and introduce a brand new query that rewrites to a Knn(Byte|Float)VectorQuery and may add a description string. Something like HumanReadableQuery(Query in, String description) that would always rewrite to its inner query?

[benwtrent]

I much prefer @jpountz idea. This additional field is purely for debugging purposes. A DebugQuery or HumanReadableQuery does seem like a good idea.

[slow-J]

Thanks for the suggestion @jpountz! I'll add a HumanReadableQuery and revert the current changes. I think it would be quite similar to the AssertingQuery.

[slow-J]

Created a HumanReadableQuery which wraps a Query and only changes the .toString() behaviour, please let me know if I misunderstood any part of the suggestion.

[benwtrent]

I wonder if a bonus here would be a wrapped weight that overrides explain and adds the human description to the output?

[jpountz]

Or we keep it as simple as possible, return the inner query in #rewrite and throw an UnsupportedOperationException in #createWeight?

[slow-J]

I'll make it as simple as possible for now, and if needed we can always extend it further.

[jpountz]

Should we move it in lucene/misc rather than lucene/core?

[slow-J]

Should we move it in lucene/misc rather than lucene/core?

Yes, that sounds like a better place for it.

[jpountz]

I left minor comments but it looks good to me otherwise!

[slow-J]

I left minor comments but it looks good to me otherwise!

Thanks for the feedback! Done the changes there.