Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KeywordField and StringValueFacetCounts example #12817

Merged
merged 1 commit into from Nov 22, 2023

Conversation

stefanvodita
Copy link
Contributor

We don't have a demo for faceting using KeywordField, SortedDocValuesField, or StringValueFacetCounts. This PR adds one, mostly inspired by SimpleSortedSetFacetsExample.

Copy link
Contributor

@msokolov msokolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @stefanvodita. This looks to be in line with the other facets demos, which are all standalone (I was a little surprised they are not integrated with IndexFiles / SearchFiles)

@msokolov msokolov merged commit a3794ca into apache:main Nov 22, 2023
4 checks passed
@msokolov
Copy link
Contributor

It just occurred to me; perhaps we should add a CHANGE log entry? And it could be nice to backport to 9.x if you like

@stefanvodita
Copy link
Contributor Author

Thank you @msokolov! I pushed a commit with a CHANGES entry. Do you need me to open a PR against the 9x branch?

msokolov pushed a commit that referenced this pull request Nov 22, 2023
msokolov pushed a commit that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants