Fix Field.java documentation to refer to new IntField/FloatField/LongField/DoubleField #12125 #12821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This particular change addresses apache#12675 MultiSimilarity.MultiSimScorer should sum up scores into a double error.
…ngField/DoubleField apache#12125
Fix Field.java documentation to refer to new IntField/FloatField/LongField/DoubleField apache#12125
Renamed Quantile to confidenceInterval
|
Thanks for doing it, it looks like the PR includes unintended changes though? |
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
|
@SreehariG73 Do you plan on removing the unintended changes? |
|
Hello Adrien,
I have made changes to the PR. Please review the same and let me know if it
looks good
regards,
Sreehari Guruprasad
…On Mon, Jan 8, 2024 at 6:08 AM Adrien Grand ***@***.***> wrote:
@SreehariG73 <https://github.com/SreehariG73> Do you plan on removing the
unintended changes?
—
Reply to this email directly, view it on GitHub
<#12821 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARA6WH34EPF6VQWYN75KPHDYNP4WVAVCNFSM6AAAAAA7PFIS2OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBRGA4DCOBUGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thank you! I'll close this one then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced IntPoint, LongPoint, FloatPoint, and DoublePoint with IntField, LongField, FloatField, and DoubleField to make it easier-to-use field subclasses.