Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hunspell: a couple micro-optimizations to speed up dictionary loading #12825

Merged
merged 3 commits into from Nov 21, 2023
Merged

hunspell: a couple micro-optimizations to speed up dictionary loading #12825

merged 3 commits into from Nov 21, 2023

Conversation

donnerpeter
Copy link
Contributor

  1. sort by the whole entry without searching for separators first: WordStorage doesn't require strong lexicographic order (only something close to it), and the separators are anyway before any usual word characters
  2. avoid stream overhead when adding an entry

Description

@donnerpeter
hunspell: a couple micro-optimizations to speed up dictionary loading
7fd4320 
1. sort by the whole entry without searching for separators first: WordStorage doesn't require strong lexicographic order (only something close to it), and the separators are anyway before any usual word characters
2. avoid stream overhead when adding an entry
gf2121
gf2121 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@gf2121 gf2121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for trying the radix sorter !

@donnerpeter donnerpeter merged commit c23b3b3 into apache:main Nov 21, 2023
5 checks passed
@donnerpeter donnerpeter deleted the naturalOrderNoStream branch November 21, 2023 07:05
donnerpeter added a commit that referenced this pull request Nov 27, 2023
@donnerpeter
hunspell: a couple micro-optimizations to speed up dictionary loading (…
778b6f8 
…#12825)

* hunspell: a couple micro-optimizations to speed up dictionary loading

1. sort by the whole entry without searching for separators first: WordStorage doesn't require strong lexicographic order (only something close to it), and the separators are anyway before any usual word characters
2. avoid stream overhead when adding an entry

(cherry picked from commit c23b3b3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweiss dweiss dweiss approved these changes

@gf2121 gf2121 gf2121 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@donnerpeter @dweiss @gf2121