Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip decoding tail freqs when they are not needed. #12832

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Skip decoding tail freqs when they are not needed. #12832

merged 2 commits into from
Nov 22, 2023

Conversation

jpountz
Copy link
Contributor

@jpountz jpountz commented Nov 22, 2023

When we moved to group-varint for tail postings, we stop interleaving docs and freqs and instead wrote all docs first, then all freqs. This means that we can now skip decoding frequencies when they are not needed.

@jpountz
Skip decoding tail freqs when they are not needed.
64ab03c 
When we moved to group-varint for tail postings, we stop interleaving docs and
freqs and instead wrote all docs first, then all freqs. This means that we can
now skip decoding frequencies when they are not needed.
@easyice
Copy link
Contributor

easyice commented Nov 22, 2023

Great idea :)

@jpountz jpountz merged commit 5bc608d into apache:main Nov 22, 2023
4 checks passed
jpountz added a commit that referenced this pull request Nov 22, 2023
@jpountz
Skip decoding tail freqs when they are not needed. (#12832)
c0cfae7 
When we moved to group-varint for tail postings, we stop interleaving docs and
freqs and instead wrote all docs first, then all freqs. This means that we can
now skip decoding frequencies when they are not needed.
@jpountz jpountz deleted the skip_tail_freqs branch November 22, 2023 09:12
@jpountz jpountz added this to the 9.9.0 milestone Nov 22, 2023
@jpountz
Copy link
Contributor Author

jpountz commented Nov 22, 2023

Thanks @easyice and @gf2121 for looking!

@jpountz
Copy link
Contributor Author

jpountz commented Nov 24, 2023

This seems to have further helped prefix queries. I'll add an annotation.

@easyice easyice mentioned this pull request Dec 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gf2121 gf2121 gf2121 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jpountz @easyice @gf2121