-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hunspell: allow in-memory entry sorting for faster dictionary loading #12834
Conversation
* @see #offline(Directory, String) | ||
* @see #inMemory() | ||
*/ | ||
public abstract class SortingStrategy { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better name ideas are welcome
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's exactly what it is - can't think of a better name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor comments.
* @see #offline(Directory, String) | ||
* @see #inMemory() | ||
*/ | ||
public abstract class SortingStrategy { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's exactly what it is - can't think of a better name?
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SortingStrategy.java
Show resolved
Hide resolved
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SortingStrategy.java
Outdated
Show resolved
Hide resolved
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SortingStrategy.java
Show resolved
Hide resolved
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SortingStrategy.java
Outdated
Show resolved
Hide resolved
…spell/SortingStrategy.java Co-authored-by: Dawid Weiss <dawid.weiss@gmail.com>
…spell/SortingStrategy.java Co-authored-by: Dawid Weiss <dawid.weiss@gmail.com>
Description