[Minor] Fix the only use of java.lang.String#toLowerCase() with no Locale #12856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
dweiss
approved these changes
Jan 8, 2024
stefanvodita
pushed a commit
to stefanvodita/lucene
that referenced
this pull request
Jan 9, 2024
slow-J
added a commit
to slow-J/lucene
that referenced
this pull request
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at this old issue: #4390
Flexible Queryparser has some Locale violation with lowercasing, which was already fixed with the work done in #5271. But I came across this single use of.toLowerCase()with no Locale in Checksum.java.TIL: forbidden apis doesn't run against the
package org.apache.lucene.gradle.