Remove stale BWC tests #12874
Merged
Remove stale BWC tests #12874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both of these tests have been disabled for quiet a long time. While `TestManyPointsInOldIndex` looks indeed stale, `TestIndexWriterOnOldIndex` is not a more general test.
jpountz
approved these changes
Dec 6, 2023
mikemccand
reviewed
Dec 7, 2023
| } | ||
|
|
||
| public void testCheckOldIndex() throws IOException { | ||
| assumeTrue("Reenable when 7.0 is released", false); |
There was a problem hiding this comment.
Doh! So I guess this test never got enabled, and now the index it is testing (which is apparently nowhere to be found in our resources) is too ancient for modern Lucene to read.
mikemccand
reviewed
Dec 7, 2023
| public class TestIndexWriterOnOldIndex extends LuceneTestCase { | ||
|
|
||
| public void testOpenModeAndCreatedVersion() throws IOException { | ||
| assumeTrue("Reenable when 8.0 is released", false); |
There was a problem hiding this comment.
Sheesh ... this makes me wonder what other assumeTrue are lurking that we failed to re-enable on XYZ release!
mikemccand
approved these changes
Dec 7, 2023
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
s1monw
added a commit
that referenced
this pull request
Jan 9, 2024
Both of these tests have been disabled for quiet a long time. While `TestManyPointsInOldIndex` looks indeed stale, `TestIndexWriterOnOldIndex` is not a more general test.
slow-J
pushed a commit
to slow-J/lucene
that referenced
this pull request
Jan 16, 2024
Both of these tests have been disabled for quiet a long time. While `TestManyPointsInOldIndex` looks indeed stale, `TestIndexWriterOnOldIndex` is not a more general test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of these tests have been disabled for quiet a long time. While
TestManyPointsInOldIndexlooks indeed stale,TestIndexWriterOnOldIndexis not a more general test.