Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An improved check for ignoring the c2-crash test if running on a client compiler. #12953

Merged
merged 3 commits into from Dec 18, 2023
Merged

An improved check for ignoring the c2-crash test if running on a client compiler. #12953

merged 3 commits into from Dec 18, 2023

Conversation

dweiss
Copy link
Contributor

@dweiss dweiss commented Dec 18, 2023 •
edited

Follow-up to #12905

@dweiss dweiss mentioned this pull request Dec 18, 2023
Merged
@uschindler
Copy link
Contributor

FYI, there's also Constants.IS_HOTSPOT_VM. Just in case :-) But I don't think that's usefil here as additional constraint.

uschindler
uschindler requested changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@uschindler uschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this method, too (it is dead code):

https://github.com/apache/lucene/pull/12953/files#diff-a55d6b740bc9510cd53e003a0f209951ea914ce3f9998fa333df95f7445a46d4R181

@uschindler
Copy link
Contributor

uschindler commented Dec 18, 2023 •
edited

This is why it works and you can still run the tests with export CI=true.

lucene/gradle/testing/defaults-tests.gradle

Line 54 in f6582ce

value: { -> propertyOrEnvOrDefault("tests.jvmargs", "TEST_JVM_ARGS", isCIBuild ? "" : "-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1") },

This PR just detects directly if Client VM is used. So it doesn't matter if it is caused by CI enabled or if you run it in your IDE with some custom config.

@dweiss
Copy link
Contributor Author

dweiss commented Dec 18, 2023

I've removed the unused method and added hotspot check, thanks Uwe.

@dweiss dweiss merged commit 6bb244a into apache:main Dec 18, 2023
4 checks passed
@dweiss dweiss changed the title Ignore the test if running on a client compiler. An improved check for ignoring the c2-crash test if running on a client compiler. Dec 18, 2023
asfgit pushed a commit that referenced this pull request Dec 18, 2023
@dweiss
An improved check for ignoring the c2-crash test if running on a clie…
41794f0 
…nt compiler. (#12953)
@dweiss
Copy link
Contributor Author

dweiss commented Dec 18, 2023 •
edited

I've applied this to main and branch_9x.

@dweiss dweiss added this to the 9.10.0 milestone Dec 18, 2023
@ChrisHegarty
Copy link
Contributor

I'm way too slow here, sorry. Belated LGTM. And thanks for following up on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uschindler uschindler uschindler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dweiss @uschindler @ChrisHegarty