Add missing spaces in concatenated strings #12967
Conversation
There was a problem hiding this comment.
Wow, thank you for the attention to detail @sabi0!
I'm curious: how did you uncover all of these corrections? Is there some static analysis tool that you started from?
| @@ -236,7 +236,7 @@ synchronized void abort() throws IOException { | |||
| } | |||
| } | |||
|
|
|||
| final boolean flushOneDWPT() throws IOException { | |||
| boolean flushOneDWPT() throws IOException { | |||
There was a problem hiding this comment.
Ahh because the class itself is already final, great!
|
|
||
| public DocIdSetIterator iterator(IndexReader r) throws IOException; |
There was a problem hiding this comment.
There is another PR about removing the not-needed public in interfaces I think.
|
I'll backport for 9.10 soon. |
|
Thank you for checking this so quickly! I started with a "Whitespace may be missing in string concatenation" inspection in IntelliJ IDEA. |
Cool! Thanks for your attention to detail. I wish we could somehow fold these checks into Lucene's static code analysis tooling... |
|
https://www.jetbrains.com/qodana/ Open source projects can get a free license for any JetBrains products: |
Mostly changing code like this
"expected: " + currentFullFlushDelQueue + "but was: "to
"expected: " + currentFullFlushDelQueue + " but was: "But also fixing bugs like
"" + i + numDocs=>"" + (i + numDocs).I took the liberty to also do some minor housekeeping in the affected files:
UTF_8,assertThat()=>assertEquals(), etc.)