Fix BWC test generation after mondernizing LineDocFile #13021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes on apache#12929 broke the generation code for BWC indices since they are expecting vertain fields created by LineDocFile. Yet, this change adds some sanity checks that run with unittest to ensure the bwc generatin is at least readable with the current version. Relates to apache#12929
jpountz
approved these changes
Jan 17, 2024
...ne/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java
Outdated
Show resolved
Hide resolved
| if (docIdDV == null) { | ||
| docIdDV = new NumericDocValuesField("docid_intDV", 0); | ||
| doc.add(docIdDV); | ||
| } |
There was a problem hiding this comment.
Nit: this seems to assume that the Document instance that is returned is always the same, which feels a bit fragile. Maybe do a shallow copy of the document all the time? Or use TestUtil.cloneDocument()?
There was a problem hiding this comment.
yeah, so we are doing this in the other tests too bef0r my change. That's why i did it that way... I can clean this all up in a followup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes on #12929 broke the generation code for BWC indices since they are expecting certain fields created by LineDocFile. Yet, this change adds some sanity checks that run with unittest to ensure the bwc generatin is at least readable with the current version.
Relates to #12929