Align instanceof check with type cast #13039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabi0
commented
Jan 29, 2024
| @@ -107,10 +105,9 @@ public QueryNode process(QueryNode queryTree) throws QueryNodeException { | |||
| @Override | |||
| protected QueryNode postProcessNode(QueryNode node) throws QueryNodeException { | |||
|
|
|||
| if (node instanceof TextableQueryNode | |||
| if (node instanceof FieldQueryNode | |||
There was a problem hiding this comment.
'node' is cast below to FieldQueryNode. But the condition here was checking for a base type TextableQueryNode, excluding some sub-types. If a new TextableQueryNode sub-type was added the code below could run into a CCE.
Having the instanceof FieldQueryNode condition here makes the type cast below safe. And also eliminates the need to exclude the RegexpQueryNode as it does not subclass FieldQueryNode.
uschindler
reviewed
Jan 29, 2024
lucene/core/src/java/org/apache/lucene/analysis/tokenattributes/PayloadAttributeImpl.java
Outdated
Show resolved
Hide resolved
|
I added the changes entry to the existing one for you. |
asfgit
pushed a commit
that referenced
this pull request
Jan 30, 2024
|
Thank you. I will make sure the new PRs have them out of the box. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.