Clean up AnyQueryNode code #13053
Merged
Clean up AnyQueryNode code #13053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed redundant field initializers - fixed a typo in the field name: `minimumMatching_m_Elements` - removed redundant `instanceof` checks - replaced type casts with a pattern variable - changed `size() == 0` to `isEmpty()` - removed unnecessary explicit `toString()` calls
|
Thank you, LGTM. Could you add a changes entry as well? |
dweiss
reviewed
Jan 30, 2024
| if (clause instanceof FieldableNode) { | ||
| ((FieldableNode) clause).setField(field); | ||
| } | ||
| if (clause instanceof FieldQueryNode qn) { |
There was a problem hiding this comment.
This won't backport to 9x, unfortunately. I'll just correct it manually when backporting. Or should we leave this on main only, @uschindler - wdyt?
There was a problem hiding this comment.
I could undo the pattern variable part, leaving it to #12295.
# Conflicts: # lucene/CHANGES.txt
uschindler
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimumMatching_m_Elementsinstanceofcheckssize() == 0toisEmpty()toString()calls