Remove redundant field initializers #13060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In many cases this allowed to mark the field as `final`
sabi0
commented
Jan 30, 2024
| @@ -32,10 +32,10 @@ | |||
| */ | |||
| public final class DaitchMokotoffSoundexFilter extends TokenFilter { | |||
| /** true if encoded tokens should be added as synonyms */ | |||
| protected boolean inject = true; | |||
| final boolean inject; | |||
There was a problem hiding this comment.
I would make these fields private, but not sure if breaking backward compatibility here would be ok?
There was a problem hiding this comment.
Since this class is marked with @lucene.experimental, we can make the change.
| @@ -32,13 +32,13 @@ | |||
| */ | |||
| public final class PhoneticFilter extends TokenFilter { | |||
| /** true if encoded tokens should be added as synonyms */ | |||
| protected boolean inject = true; | |||
| final boolean inject; | |||
There was a problem hiding this comment.
Could be changed to private too?
There was a problem hiding this comment.
It's a strange case. We're not really breaking backwards compatibility, since no one could have accessed this field anyway with the class being final.
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
stefanvodita
approved these changes
Feb 14, 2024
stefanvodita
pushed a commit
that referenced
this pull request
Feb 19, 2024
Make protected fields in final classes private.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many cases this allowed to mark the field as
final.