-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hunspell: allow ignoring exceptions on duplicate ICONV/OCONV mappings #13155
Conversation
To backport to Lucene 9_x |
LGTM. A changes.txt entry is missing. Did you mean to assign this to me or just assign me as a reviewer? :) |
@dweiss Oh sorry. I meant you as a reviewer :) |
They do go to main with changes under the corresponding 9.x section - then you can typically cherry pick the same commit when backporting. |
So, on main they'd go somewhere below this place: |
Does it make sense to allow this by default? I don't know how |
@rmuir An interesting idea. Such duplication appears to be a relatively rare condition, not present in the two major dictionary collections I've been testing against. On the other hand, people would need to recompile their code if they find they face such dictionaries. On yet another hand, people might be more motivated to fix the faulty dictionaries. I'm unsure :( |
No description provided.