Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hunspell: allow ignoring exceptions on duplicate ICONV/OCONV mappings #13155

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

donnerpeter
Copy link
Contributor

No description provided.

@donnerpeter
Copy link
Contributor Author

To backport to Lucene 9_x

@dweiss
Copy link
Contributor

dweiss commented Mar 4, 2024

LGTM. A changes.txt entry is missing. Did you mean to assign this to me or just assign me as a reviewer? :)

@donnerpeter
Copy link
Contributor Author

donnerpeter commented Mar 4, 2024

LGTM. A changes.txt entry is missing. Did you mean to assign this to me or just assign me as a reviewer? :)

@dweiss Oh sorry. I meant you as a reviewer :)
Is the changes.txt entry needed if I backport this to 9_x (and add the entry there)? AFAIU the changes for 10.0 shouldn't include stuff that's in 9_x? Or am I mistaken?

@dweiss
Copy link
Contributor

dweiss commented Mar 4, 2024

They do go to main with changes under the corresponding 9.x section - then you can typically cherry pick the same commit when backporting.

@dweiss
Copy link
Contributor

dweiss commented Mar 4, 2024

So, on main they'd go somewhere below this place:
https://github.com/apache/lucene/blob/main/lucene/CHANGES.txt#L184

@rmuir
Copy link
Member

rmuir commented Mar 4, 2024

Does it make sense to allow this by default? I don't know how hunspell behaves here, but I've seen crazy stuff in these dictionaries...

@donnerpeter
Copy link
Contributor Author

Does it make sense to allow this by default? I don't know how hunspell behaves here, but I've seen crazy stuff in these dictionaries...

@rmuir An interesting idea. Such duplication appears to be a relatively rare condition, not present in the two major dictionary collections I've been testing against. On the other hand, people would need to recompile their code if they find they face such dictionaries. On yet another hand, people might be more motivated to fix the faulty dictionaries. I'm unsure :(

@donnerpeter donnerpeter merged commit 44d48df into apache:main Mar 5, 2024
4 checks passed
@donnerpeter donnerpeter deleted the dupMapping branch March 5, 2024 08:54
donnerpeter added a commit that referenced this pull request Mar 7, 2024
…#13155)

hunspell: allow ignoring exceptions on duplicate ICONV/OCONV mappings
(cherry picked from commit 44d48df)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants