-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand scalar quantization with adding half-byte (int4) quantization #13197
Merged
benwtrent
merged 24 commits into
apache:main
from
benwtrent:feature/improve-int8-quantization
Apr 2, 2024
Merged
Changes from 18 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
c57af13
Improve int8 recall by better auto quantile calculation
benwtrent 1d6cff0
fixing scalar quantization
benwtrent b822b43
fixing minor bug
benwtrent 0e62932
adding int4
benwtrent 2ae25c0
iter
benwtrent 023cf85
Merge remote-tracking branch 'upstream/main' into feature/improve-int…
benwtrent c15f7a5
iter
benwtrent f2ac8af
iter
benwtrent dc16431
iter
benwtrent b10d301
Adding panama support for halfbyte
benwtrent f1f69eb
updating benchmark
benwtrent 97dc28d
iter
benwtrent 7e70783
iter
benwtrent bdcddc8
requantize always on bit4
benwtrent 87ca60a
iter
benwtrent e89bde6
iter panama
benwtrent 30e3b8e
Merge remote-tracking branch 'upstream/main' into feature/improve-int…
benwtrent 9cc5251
add changes
benwtrent 8a06cf5
restricting bits and reverting benchmark change
benwtrent 69bf584
Add BWC tests for core scalar quantized HNSW codec
benwtrent f675647
Merge remote-tracking branch 'upstream/main' into feature/add-int8-bw…
benwtrent 63b15c2
Merge branch 'feature/add-int8-bwc-tests' into feature/improve-int8-q…
benwtrent 5c8227b
Adding bwc tests for int8hnsw
benwtrent 31b5351
Merge remote-tracking branch 'upstream/main' into feature/improve-int…
benwtrent File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we keep the other options too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this was a mistake to commit this change, I was benchmarking :/