UnifiedHighlighter highlight on multiple fields #13268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayya-sharipova
force-pushed
the
unified-highlighter-multi-fields
branch
2 times, most recently
from
0f00284
to
147b57e
Compare
jimczi
reviewed
Apr 8, 2024
There was a problem hiding this comment.
This is a great addition @mayya-sharipova .
I left a comment regarding the exposure, we should also document the limit of the feature (input should be identical for all masked fields).
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java
Outdated
Show resolved
Hide resolved
Add ability to UnifiedHighlighter to combine matches from multiple fields to highlight a single field. FastVectorHighlighter for a long time has an option to highlight a single field based on matches from several fields. But UnifiedHighlighter was missing this option. This adds this ability.
mayya-sharipova
force-pushed
the
unified-highlighter-multi-fields
branch
from
147b57e
to
30a63b0
Compare
|
@jimczi Thanks for your initial review. I've tried to address all your comments, so this is ready for another review. |
jimczi
reviewed
Apr 10, 2024
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/UnifiedHighlighter.java
Show resolved
Hide resolved
mayya-sharipova
added a commit
to mayya-sharipova/lucene
that referenced
this pull request
Apr 12, 2024
Add ability to UnifiedHighlighter to combine matches from multiple fields to highlight a single field. FastVectorHighlighter for a long time has an option to highlight a single field based on matches from several fields. But UnifiedHighlighter was missing this option. This adds this ability with a new function: `UnifiedHighlighter::withMaskedFieldsFunc` that sets up a function that given a field retuns a set of masked fields whose matches are combined to highlight the given field.
mayya-sharipova
added a commit
to mayya-sharipova/lucene
that referenced
this pull request
Apr 12, 2024
Add ability to UnifiedHighlighter to combine matches from multiple fields to highlight a single field. FastVectorHighlighter for a long time has an option to highlight a single field based on matches from several fields. But UnifiedHighlighter was missing this option. This adds this ability with a new function: `UnifiedHighlighter::withMaskedFieldsFunc` that sets up a function that given a field retuns a set of masked fields whose matches are combined to highlight the given field.
mayya-sharipova
added a commit
that referenced
this pull request
Apr 12, 2024
Add ability to UnifiedHighlighter to combine matches from multiple fields to highlight a single field. FastVectorHighlighter for a long time has an option to highlight a single field based on matches from several fields. But UnifiedHighlighter was missing this option. This adds this ability with a new function: `UnifiedHighlighter::withMaskedFieldsFunc` that sets up a function that given a field retuns a set of masked fields whose matches are combined to highlight the given field. Backport for PR #13268
mayya-sharipova
added a commit
to mayya-sharipova/elasticsearch
that referenced
this pull request
Apr 18, 2024
Add support to the Uunified highlighter to combine matches on multiple fields to highlight a single field: "matched_fields". Based on Lucene PR: apache/lucene#13268 Lucene PR is based on the concept of masked fields where masked fields are different from the original highlighted field. This PR in Elasticsearch uses the already existing highlighter parameter "matched_fields" Closes elastic#5172
mayya-sharipova
added a commit
to elastic/elasticsearch
that referenced
this pull request
May 9, 2024
Add support to the Unified highlighter to combine matches on multiple fields to highlight a single field: "matched_fields". Based on Lucene PR: apache/lucene#13268 Lucene PR is based on the concept of masked fields where masked fields are different from the original highlighted field. This PR in Elasticsearch uses the already existing highlighter parameter "matched_fields".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to UnifiedHighlighter to combine matches from multiple fields
to highlight a single field.
FastVectorHighlighter for a long time has an option to highlight a single field
based on matches from several fields. But UnifiedHighlighter was missing this option.
This adds this ability.