Narrow MASKS and UTF8Byte.value's type, assign MASKS by left shift in UTF32ToUTF8 #13310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikemccand |
vsop-479
changed the title
vsop-479
changed the title
mikemccand
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Thanks @vsop-479 -- nice to see another TODO done! Silly that this code was using int to represent what is really only a byte.
mikemccand
pushed a commit
that referenced
this pull request
Apr 23, 2024
… UTF32ToUTF8 (#13310) * Change MASKS from int[] to byte[], and assign it with left shift. * Only set first byte for tmpUTF8. * Only set first byte value for tmp utf8. * Change value type from int to byte. * Remove stale comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change
MASKSfromint[]tobyte[], and assign it with left shift inUTF32ToUTF8.Edit:
This change also implemented:
Only set first byte value for tmp UTF8.
Change
UTF8Byte.valuetype frominttobyte.