Replace Map<Long, Object> by primitive LongObjectHashMap. #13392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweiss
approved these changes
May 20, 2024
| @@ -16,8 +16,10 @@ | |||
| */ | |||
|
|
|||
| /** Index-time and Query-time joins for normalized content */ | |||
| @SuppressWarnings({"requires-automatic"}) | |||
There was a problem hiding this comment.
I should make hppc a proper module, really... I'll try to do this soon.
uschindler
approved these changes
May 20, 2024
bruno-roustant
added a commit
that referenced
this pull request
May 23, 2024
Add LongObjectHashMap and replace Map<Long, Object>. Add LongIntHashMap and replace Map<Long, Int>. Add HPPC dependency to join and spatial modules for primitive values float and double.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes, only replacements by primitve maps.
Adds LongObjectHashMap and LongIntHashMap to the org.apache.lucene.util.hppc package, with some refactoring.
Adds a dependency to com.carrotsearch.hppc to the join and spatial modules. This dependency is already present in the facet module. This way these packages can use primitive hash map with float or double values.
The changes in the JoinUtil class are a good example of usage of primitive structures. This highly reduces the auto-boxing around primitives.