LUCENE-9983: Stop sorting determinize powersets unnecessarily #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
determinize
function (which truns NFA to DFA), we useSortedIntSet
to store powerset and it uses a sorted data structure which could be very costly in some cases. And we actually don't need the sorting functionality.Solution
Replace usage of
SortedIntSet
byStateSet
, a wrapper ofIntIntHashMap
. Note I haven't removedSortedIntSet
but probably we should since it is only used indeterminize
?Tests
SortedIntSet
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.