LUCENE-9990: gradle7 support #175
Conversation
gradle/java/javac.gradle
Outdated
| } | ||
| } | ||
|
|
||
| tasks.withType( JavaCompile ).configureEach { |
There was a problem hiding this comment.
Add the issue reference you mentioned here. The entire workaround thing should be best moved under a separate file in gradle/hacks.
There was a problem hiding this comment.
Thanks for adding and reviewing the patch!
Sure. gradle/hacks makes sense. I'll also follow up on the ticket to see if there is a better way to solve this.
| } | ||
| } | ||
| } | ||
| //JavaInstallationRegistry registry = extensions.getByType(JavaInstallationRegistry) |
There was a problem hiding this comment.
I understand it's a PoC but a plan is needed how to enable what worked previously - pointing at an arbitrary JVM home and have it be the default for compilation, tests, etc. In the current form the patch removes things that are currently used to separate the gradle vs. lucene JVM toolchains - we do need this separation (for example to rule out early access JVM problems stemming from gradle itself vs. lucene).
There was a problem hiding this comment.
Sure.
Gradle 7 has something similar to what we have already setup today i.e., using an env variable to send in the location of the JVM. I can get it running and then add instructions in lucene/help/jvms.txt, cleanup the comments in this file as well!
There was a problem hiding this comment.
Just to be clear: I don't know how it works exactly but what we want is not one jvm to run gradle and lucene - we want the ability to separate these.
There was a problem hiding this comment.
Understood :) The gradle website says this (under improvements in Gradle 7):
Additionally, you may want to build a project using a Java version that is not supported for running Gradle.
so I am optimistic that we should be able to run Gradle and Lucene on different Java versions.
Sorry for the delay in the response! I will try my best to find some time soon and get this running
There was a problem hiding this comment.
No worries at all. I think Palantir's plugin is the showstopper here too.
|
I gave this PR another shot (since the Palantir plugin has been patched in v2.0.0 for Gradle 7 support), but had some new issues come up. The good news, I think that using the Some WIP code is pushed here. |
No description provided.