LUCENE-9849: Don't cross-link between modules for interim snapshot builds. #21
Conversation
|
Hey, @uschindler do you want to take a peek? Or should I just commit this in and we can follow-up with other improvements later on? |
There was a problem hiding this comment.
Looks fine.
I was too tired yesterday to do this. I was also stuck on the RenderJavaDocsTask property with the link not able to handle null correctly.
This is exactly what I expected. Those code here should be done in same way on the Solr, side. But as code heavy diverges, we should make a separate PR.
| // Add offline links. | ||
| allOfflineLinks.each { url, dir -> | ||
| // Some sanity check/ validation here to ensure dir/package-list or dir/element-list is present. | ||
| if (!project.file("$dir/package-list").exists() && | ||
| !project.file("$dir/element-list").exists()) { | ||
| throw new GradleException("Expected pre-rendered package-list or element-list at ${dir}.") | ||
| } | ||
| logger.lifecycle("Linking ${url} to ${dir}") |
There was a problem hiding this comment.
I think this should be a lower log level, you used lifecycle to actually see output, right?
| @@ -284,7 +282,8 @@ class RenderJavadocTask extends DefaultTask { | |||
| def offlineLinks = [:] | |||
|
|
|||
| @Input | |||
| def luceneDocUrl = "${-> project.luceneDocUrl }" | |||
| @Optional | |||
| Property<String> luceneDocUrl = project.objects.property(String) | |||
There was a problem hiding this comment.
How to do this part I was missing yesterday (my javadocs then contained the string "null" as URL..... Property is the one I was looking for! Great! Much better than before.
| } else { | ||
| // For absolute links, we determine the target URL by assembling the full URL (if base is available). | ||
| def value = luceneDocUrl.getOrElse(null) | ||
| if (value) { |
There was a problem hiding this comment.
great! My code yesterday looked similar!
This isn't ideal - I think the root property luceneDocUrl should be moved to render-javadoc, but it's a start?