Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-10046: Fix counting bug in StringValueFacetCounts #236

Merged
merged 1 commit into from
Aug 7, 2021

Conversation

gsmiller
Copy link
Contributor

@gsmiller gsmiller commented Aug 7, 2021

Description

Fixes a counting bug in StringValueFacetCounts exposed on a specific execution path.

Solution

Make sure to map to a global ordinal as necessary.

Tests

Added a new test case to expose the issue.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Lucene maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.

@gsmiller gsmiller merged commit e937e73 into apache:main Aug 7, 2021
@gsmiller
Copy link
Contributor Author

gsmiller commented Aug 7, 2021

Pushing this fix without a review since as it's a simple change and kind of a nasty edge-case bug. Happy to iterate on this / incorporate feedback post-push if anyone has thought though.

@gsmiller gsmiller deleted the LUCENE-10046 branch August 7, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant