LUCENE-10047: Fix value de-duping check in LongValueFacetCounts and RangeFacetCounts #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pushing without a review to unblock broken nightly build test runs. Happy to tweak this further if anyone has feedback though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These two facet counting implementations are incorrectly assuming that -1 is an invalid value (for the purpose of value de-duping), which isn't the case.
Solution
Fix the above assumption.
Tests
Existing randomized testing caught the bug. Tests now pass.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.