LUCENE-10057: Use Lucene abstractions to store KnnVectorDict #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks very well, now the dict file is created using IndexOutput and read in using IndexInput. And it is also stored in index directory. I am not sure if storing in index directory is the best idea, because it is not part of segmentinfos, so the index itsself does not know about the file. But when this gets improved maybe we have a standard FST format available that is "officially part of index". |
dweiss
approved these changes
Aug 19, 2021
| @@ -153,6 +163,10 @@ public static void main(String[] args) throws Exception { | |||
| // you're done adding documents to it): | |||
| // | |||
| // writer.forceMerge(1); | |||
| } finally { | |||
| if (vectorDictInstance != null) { | |||
There was a problem hiding this comment.
IOUtils.close(vararg) can deal with null entries so you can omit the if here.
There was a problem hiding this comment.
ah I didn't realize, thanks I'll change that and push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.