LUCENE-10232: Fix MultiRangeQuery to confirm all dimensions for a given range match #437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MultiRangeQuery
was incorrectly considering a range to match if at least one dimension matched (instead of requiring all dimensions to match).Solution
Corrected the logic in
MultiRangeQuery
. Also updated comparisons to useArrayUtil.ByteArrayComparator
.Tests
Updated existing tests to expose the bug and confirmed the fix addresses it.
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.