-
Notifications
You must be signed in to change notification settings - Fork 966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LUCENE-10297: Speed up medium cardinality fields with readLongs and SIMD #530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gf2121
changed the title
LUCENE-10297: Speed up medium cardinality fields with readLELongs and SIMD
LUCENE-10297: Speed up medium cardinality fields with readLongs and SIMD
Dec 9, 2021
gf2121
commented
Dec 13, 2021
import org.apache.lucene.store.FSDirectory; | ||
|
||
/** java doc */ | ||
public class Run { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the benchmark script, i post it here in case someone would like to play with it. I'll delete this file later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced a bitset optimization for extremly low cardinality fields in https://issues.apache.org/jira/browse/LUCENE-10233, but medium cardinality fields (like 32/128) can rarely trigger this optimization, I'm trying to find out a way to speed up them.
In apache/lucene-solr#1538, we made some effort to use readLELongs to speed up BKD id blocks, but did not get a obvious gain on this approach. I think the reason could probably be that we were trying to optimize the unsorted situation (typically happens for high cardinality fields) and the bottleneck of queries on high cardinality fields is
visitDocValues
but notreadDocIds
.However, medium cardinality fields may be tempted for this optimization because they need to read lots of ids for each term. The basic idea is that we can compute the delta of the sorted ids and encode/decode them like what we do in
StoredFieldsInts
. I benchmarked the optimization by mocking some random longPoint and querying them withPointInSetQuery
. As expected, the medium cardinality fields got spped up and high cardinality fields get even results.Benchmark Result