LUCENE-10331: don't emit the contents of the inputs file until we're actually running the task #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actually running the task.
|
This should do it, @rmuir |
rmuir
approved these changes
Dec 20, 2021
There was a problem hiding this comment.
looks good, so we were creating the file at task definition time, which meant clean would always then wipe it? You probably don't even need a 2-core laptop to hit it :)
was able to reproduce the original problem against main branch with a gradle clean check. Can confirm gradle clean check works again with this fix. Thanks!
Yep. the separation of evaluation/ configuration/ execution stages and what happens when is the meanest part of gradle in my experience. |
dweiss
added a commit
that referenced
this pull request
Dec 20, 2021
…actually running the task (#554)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.