Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LUCENE-10335: Deprecate broken helper methods not compatible with module system; add ModuleResourceLoader and add integration test #567

Merged
merged 21 commits into from
Jan 3, 2022
Merged

LUCENE-10335: Deprecate broken helper methods not compatible with module system; add ModuleResourceLoader and add integration test #567

merged 21 commits into from
Jan 3, 2022

Commits on Dec 23, 2021

  1. LUCENE-10335: Deprecate IOUtils.getDecodingReader(Class<?>, String) f… 

    …or removal, as broken with modules
    @uschindler
    uschindler committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    8b62125 View commit details
    Browse the repository at this point in the history

  2. Fix Luke image loading with module system

    @uschindler
    uschindler committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    327a17f View commit details
    Browse the repository at this point in the history

  3. More fixes and usage of new method

    @uschindler
    uschindler committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    b0d9a5f View commit details
    Browse the repository at this point in the history

  4. Deprecate method, but not yet replace it

    @uschindler
    uschindler committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    1efa7e2 View commit details
    Browse the repository at this point in the history

  5. Add same check like in core

    @uschindler
    uschindler committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    21fa8d2 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2021

  1. merge main

    @mocobeta
    mocobeta committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    d148d57 View commit details
    Browse the repository at this point in the history

  2. correct merge error in luke module

    @mocobeta
    mocobeta committed Dec 26, 2021
    Configuration menu
    Copy the full SHA
    ee64e33 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2021

  1. Merge branch 'main' into jira/LUCENE-10335

    @uschindler
    uschindler committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    76d22a7 View commit details
    Browse the repository at this point in the history

  2. Fix the remaining deprecated StopwordAnalyzerBase method

    @uschindler
    uschindler committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    4a7e856 View commit details
    Browse the repository at this point in the history

  3. More cleanup by adding convenience methods to WordlistLoader

    @uschindler
    uschindler committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    b0344cf View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2021

  1. Refactor

    @uschindler
    uschindler committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    5daf595 View commit details
    Browse the repository at this point in the history

  2. Add a ModuleResourceLoader and a corresponding integration test

    @uschindler
    uschindler committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    2249be2 View commit details
    Browse the repository at this point in the history

  3. Cleanup test and add check for non-open resource

    @uschindler
    uschindler committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    117559f View commit details
    Browse the repository at this point in the history

  4. Add final

    @uschindler
    uschindler committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    3fe013a View commit details
    Browse the repository at this point in the history

  5. Cleanup code duplication, add more documentation about module system

    @uschindler
    uschindler committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    a45ca4f View commit details
    Browse the repository at this point in the history

  6. Add helper text to exception

    @uschindler
    uschindler committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    459e900 View commit details
    Browse the repository at this point in the history

  7. use Class.getResource... instead of ClassLoader.getResource... in kur… 

    …oomji and nori dictionary loader
    @mocobeta @uschindler
    mocobeta authored and uschindler committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    82b78c1 View commit details
    Browse the repository at this point in the history

  8. Revert some of @mocobeta's code to keep backwards compatibility; just… 

    … prepend "/" to resource path
    @uschindler
    uschindler committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    96d8939 View commit details
    Browse the repository at this point in the history

  9. Apply cleanup to 3 more places

    @uschindler
    uschindler committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    b37fd6e View commit details
    Browse the repository at this point in the history

  10. fix javadocs after copypaste

    @uschindler
    uschindler committed Dec 31, 2021
    Configuration menu
    Copy the full SHA
    030e382 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2022

  1. Add changes

    @uschindler
    uschindler committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    a5110d7 View commit details
    Browse the repository at this point in the history