Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LUCENE-10328: Module path for compiling and running tests is wrong #571

Merged
merged 48 commits into from
Jan 5, 2022
Merged

LUCENE-10328: Module path for compiling and running tests is wrong #571

merged 48 commits into from
Jan 5, 2022

Commits on Dec 22, 2021

  1. Non-functional changes cleaning up code

    @dweiss
    dweiss committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    e8435cc View commit details
    Browse the repository at this point in the history

  2. Cleanups and refactorings without functional changes.

    @dweiss
    dweiss committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    aaae8a6 View commit details
    Browse the repository at this point in the history

  3. Make sure configurations use jar artifacts instead of split class+res… 

    …ource folders.
    @dweiss
    dweiss committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    7d0b70b View commit details
    Browse the repository at this point in the history

  4. Work in progress, to be reverted and flattened.

    @dweiss
    dweiss committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    bd0e82b View commit details
    Browse the repository at this point in the history

  5. Convert some more modules to use test framework on module path

    @dweiss
    dweiss committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    7519283 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2021

  1. LUCENE-10337: workaround for xerces and split packages.

    @dweiss
    dweiss committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    9fe2855 View commit details
    Browse the repository at this point in the history

  2. LUCENE-10335: IOUtils.getDecodingReader(Class<?>, String) is broken w… 

    …ith modules/
    @dweiss
    dweiss committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    7743921 View commit details
    Browse the repository at this point in the history

  3. LUCENE-10338: Scan for tests only by convention file name pattern (Te… 

    …st*)
    @dweiss
    dweiss committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    95c5754 View commit details
    Browse the repository at this point in the history

  4. Follow-up to test convention moved.

    @dweiss
    dweiss committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    b8d445f View commit details
    Browse the repository at this point in the history

  5. Use modular deps in the replicator.

    @dweiss
    dweiss committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    0f8678b View commit details
    Browse the repository at this point in the history

  6. Separate spatial-extras test features into a separate subproject. The… 

    … test fixtures plugin provides another layer of complexity to managing dependencies - the gain is so minimal here that I removed it.
    @dweiss
    dweiss committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    7e0f1dc View commit details
    Browse the repository at this point in the history

  7. Force certain projects to compile/run test in classpath mode until ci… 

    …rcular dependncies can be figured out.
    @dweiss
    dweiss committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    6d88a74 View commit details
    Browse the repository at this point in the history

  8. Separate spatial-extras test features into a separate subproject.

    @dweiss
    dweiss committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    605ac4d View commit details
    Browse the repository at this point in the history

  9. Separate spatial-extras test features into a separate subproject.

    @dweiss
    dweiss committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    c00fb51 View commit details
    Browse the repository at this point in the history

  10. Update locks.

    @dweiss
    dweiss committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    5904448 View commit details
    Browse the repository at this point in the history

  11. Tweak the output from source validation. Remove NOCOMMITs, they're re… 

    …ally todos.
    @dweiss
    dweiss committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    dd0fba5 View commit details
    Browse the repository at this point in the history

  12. Revert "LUCENE-10335: IOUtils.getDecodingReader(Class<?>, String) is … 

    …broken with modules/"

This reverts commit 7743921.
    @dweiss
    dweiss committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    42a7472 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2021

  1. Permit gradle versions with a matching base version (for debugging gr… 

    …adle itself).
    @dweiss
    dweiss committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    a1f5f14 View commit details
    Browse the repository at this point in the history

  2. Apply Uwe's patch for LUCENE-10335

    @dweiss
    dweiss committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    8f0cbb2 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into LUCENE-10328

    @dweiss
    dweiss committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    067c9f4 View commit details
    Browse the repository at this point in the history

  4. Tidy.

    @dweiss
    dweiss committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    9b16978 View commit details
    Browse the repository at this point in the history

  5. LUCENE-10338: make TestPosition an internal class inside TrivialLooka… 

    …headFilter so that it's not picked up as a test.
    @dweiss
    dweiss committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    0875392 View commit details
    Browse the repository at this point in the history

  6. Multiple-mode rendering of module-path and classpath.

    @dweiss
    dweiss committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    d0abc12 View commit details
    Browse the repository at this point in the history

  7. Add oddball hacks for ECJ which otherwise fails with errors. Nekohtml… 

    … is a sad case of difference in how javac and ecj consider classes on module path vs. classpath
    @dweiss
    dweiss committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    d7ff7e1 View commit details
    Browse the repository at this point in the history

  8. Correct javadoc.

    @dweiss
    dweiss committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    66977bc View commit details
    Browse the repository at this point in the history

  9. Remaining fixes to get check to pass

    @dweiss
    dweiss committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    f561e4f View commit details
    Browse the repository at this point in the history

  10. Run projects with modular tests with proper modular path - combined c… 

    …lasses, resources, etc.
    @dweiss
    dweiss committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    3f6069e View commit details
    Browse the repository at this point in the history

  11. Correct jar separation between source sets, add a test validating mod… 

    …ularity.
    @dweiss
    dweiss committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    df58882 View commit details
    Browse the repository at this point in the history

  12. Add a runtime modular path dependency check.

    @dweiss
    dweiss committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    cb420e2 View commit details
    Browse the repository at this point in the history

  13. Don't tweak the paths for intellij.

    @dweiss
    dweiss committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    b6ae29b View commit details
    Browse the repository at this point in the history

  14. Removing the main sourceset module - works with gradle but confuses i… 

    …ntellij and IDEs are important.
    @dweiss
    dweiss committed Dec 27, 2021
    Configuration menu
    Copy the full SHA
    152bb76 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2021

  1. Add an awkward exclusion to break circular dependency in spatial3d

    @dweiss
    dweiss committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    d5a408e View commit details
    Browse the repository at this point in the history

  2. Add some initial module-patching infrastructure that tries not to bre… 

    …ak IDEs. Compile spatial3d with this.
    @dweiss
    dweiss committed Dec 29, 2021
    Configuration menu
    Copy the full SHA
    f87acbf View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2021

  1. Merging changes from uschindler:jira/LUCENE-10335

    @dweiss
    dweiss committed Dec 30, 2021
    Configuration menu
    Copy the full SHA
    b3b3168 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2022

  1. Revert "Merging changes from uschindler:jira/LUCENE-10335" 

    This reverts commit b3b3168.
    @dweiss
    dweiss committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    855694c View commit details
    Browse the repository at this point in the history

  2. Merging with main.

    @dweiss
    dweiss committed Jan 1, 2022
    Configuration menu
    Copy the full SHA
    4366944 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2022

  1. LUCENE-10344: force ecj to run in classpath mode for projects/sources… 

    …ets that are patched.
    @dweiss
    dweiss committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    3265a67 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://gitbox.apache.org/repos/asf/lucene int… 

    …o LUCENE-10328
    @uschindler
    uschindler committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    e91d84c View commit details
    Browse the repository at this point in the history

  3. Revert some changes that were better fixed in other PR

    @uschindler
    uschindler committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    c76d65e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into LUCENE-10328

    @uschindler
    uschindler committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    66509ff View commit details
    Browse the repository at this point in the history

  5. Edit comment.

    @dweiss
    dweiss committed Jan 3, 2022
    Configuration menu
    Copy the full SHA
    d88f5cf View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2022

  1. Merge remote-tracking branch 'origin/main' into LUCENE-10328

    @dweiss
    dweiss committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    1aac2dc View commit details
    Browse the repository at this point in the history

  2. Use test source set constant.

    @dweiss
    dweiss committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    c6363fc View commit details
    Browse the repository at this point in the history

  3. Add decision tree on how to configure classpath/ modular mode.

    @dweiss
    dweiss committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    c175e21 View commit details
    Browse the repository at this point in the history

  4. Make morfologik.tests extend from (modular) lucene test-framework.

    @dweiss
    dweiss committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    938e01b View commit details
    Browse the repository at this point in the history

  5. Make core.tests utilize the test framework in a normal, modular way.

    @dweiss
    dweiss committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    d689960 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/main' into LUCENE-10328

    @dweiss
    dweiss committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    67ecf7f View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Merge branch 'main' into LUCENE-10328

    @dweiss
    dweiss committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    d1f3732 View commit details
    Browse the repository at this point in the history