LUCENE-10378 Implement Weight#count for PointRangeQuery #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
reviewed
Feb 8, 2022
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
Outdated
Show resolved
Hide resolved
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
Outdated
Show resolved
Hide resolved
Still needs some logic to handle leaf nodes Refactored common check args to a separate function
jpountz
reviewed
Feb 9, 2022
…at matched, fix leafNode counting logic, edit comment about the condition under which our optimization is fired
gautamworah96
commented
Feb 9, 2022
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
Outdated
Show resolved
Hide resolved
jpountz
reviewed
Feb 9, 2022
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
Outdated
Show resolved
Hide resolved
…BiFunction and Predicate for internal node and leaf node respectively. Simplify code overall
iverase
reviewed
Feb 10, 2022
lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java
Outdated
Show resolved
Hide resolved
…ren lie in the range are directly added to the matchingNodeCount array, no intermediaries
iverase
reviewed
Feb 12, 2022
|
I will push this tomorrow if it is ok with you @gautamworah96 |
|
Yes. I was wondering why you had kept it open :) |
iverase
pushed a commit
to iverase/lucene
that referenced
this pull request
Feb 16, 2022
Implement Weight#count for PointRangeQuery to provide a faster way to calculate the number of matching range docs when each doc has at-most one point and the points are 1-dimensional.
|
@iverase I see you already opened a backport PR. Thanks! I'll approve that as well |
iverase
added a commit
that referenced
this pull request
Feb 16, 2022
Implement Weight#count for PointRangeQuery to provide a faster way to calculate the number of matching range docs when each doc has at-most one point and the points are 1-dimensional.
dantuzi
pushed a commit
to SeaseLtd/lucene
that referenced
this pull request
Mar 10, 2022
Implement Weight#count for PointRangeQuery to provide a faster way to calculate the number of matching range docs when each doc has at-most one point and the points are 1-dimensional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement Weight#count on PointRangeQuery. Also fixed a small style inconsistency that I noticed
Issue: https://issues.apache.org/jira/browse/LUCENE-10378
Solution
Use a similar approach to what we've done for
TermQueryorNormsFieldExistsQuery. Added initial checks for validating the input and then checking if all documents have at-least one point, the field is single dimensional and the number of points equals the number of documents.Note: @jpountz I think I've misinterpreted your
by only counting matches on the two leaves that cross with the query.comment and have implemented a brute force approach.Tests
Tests have not been added. I'm in the process of writing them
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.