Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LUCENE-10400: revise binary dictionaries' constructor in nori #693

Merged
merged 2 commits into from Feb 20, 2022
Merged

LUCENE-10400: revise binary dictionaries' constructor in nori #693

merged 2 commits into from Feb 20, 2022

Conversation

mocobeta
Copy link
Contributor

@mocobeta mocobeta commented Feb 19, 2022 •
edited

This applies the same changes as #643 to Nori.

  • Add new constructors that take Path objects to load external resources.
  • Add tests for the new constructors.
  • Deprecate the old constructors to switch the resource location (classpath/file path).
  • Always use Class.getResourceAsStream() to load class resources.

@mocobeta mocobeta mentioned this pull request Feb 19, 2022
Merged
uschindler
uschindler approved these changes Feb 19, 2022
View reviewed changes
Copy link
Contributor

@uschindler uschindler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I did not look closely but looks like you just merged the changes to the other source tree.

We will also have a second PR to remove the deprecated APIs in main branch?

@mocobeta
Copy link
Contributor Author

We will also have a second PR to remove the deprecated APIs in main branch?

Yes, I will.

@mocobeta mocobeta merged commit 58fa95d into apache:main Feb 20, 2022
@mocobeta mocobeta deleted the lucene-10400-cleanup-nori-dictionary branch February 20, 2022 07:16
mocobeta added a commit that referenced this pull request Feb 20, 2022
@mocobeta
LUCENE-10400: revise binary dictionaries' constructor in nori (#693)
e3a7d27
@mocobeta mocobeta mentioned this pull request Feb 20, 2022
Merged
wjp719 added a commit to wjp719/lucene that referenced this pull request Feb 23, 2022
@wjp719
Merge branch 'main' into feature/binary_search_in_bkd
53b96bf 
* main:
  migrate to temurin (apache#697)
  LUCENE-10424: Optimize the "everything matches" case for count query in PointRangeQuery (apache#691)
  LUCENE-10416: Update Korean Dictionary to mecab-ko-dic-2.1.1-20180720 for Nori
  Remove deprecated constructors in Nori (apache#695)
  LUCENE-10400: revise binary dictionaries' constructor in nori (apache#693)
  LUCENE-10408: Fix vector values iteration bug (apache#690)
  Temporarily mute TestKnnVectorQuery#testRandomWithFilter
  LUCENE-10382: Support filtering in KnnVectorQuery (apache#656)
  LUCENE-10084: Rewrite DocValuesFieldExistsQuery to MatchAllDocsQuery when all docs have the field (apache#677)
  Add CHANGES entry for LUCENE-10398
  LUCENE-10398: Add static method for getting Terms from LeafReader (apache#678)
  LUCENE-10408 Better encoding of doc Ids in vectors (apache#649)
  LUCENE-10415: FunctionScoreQuery and IndexOrDocValuesQuery delegate Weight#count. (apache#685)
wjp719 added a commit to wjp719/lucene that referenced this pull request Feb 23, 2022
@wjp719
Merge branch 'main' into feature/get_current_index_of_postings
70ee4e0 
* main:
  LUCENE-10416: move changes entry to v10.0.0
  migrate to temurin (apache#697)
  LUCENE-10424: Optimize the "everything matches" case for count query in PointRangeQuery (apache#691)
  LUCENE-10416: Update Korean Dictionary to mecab-ko-dic-2.1.1-20180720 for Nori
  Remove deprecated constructors in Nori (apache#695)
  LUCENE-10400: revise binary dictionaries' constructor in nori (apache#693)
  LUCENE-10408: Fix vector values iteration bug (apache#690)
  Temporarily mute TestKnnVectorQuery#testRandomWithFilter
  LUCENE-10382: Support filtering in KnnVectorQuery (apache#656)
  LUCENE-10084: Rewrite DocValuesFieldExistsQuery to MatchAllDocsQuery when all docs have the field (apache#677)
  Add CHANGES entry for LUCENE-10398
  LUCENE-10398: Add static method for getting Terms from LeafReader (apache#678)
  LUCENE-10408 Better encoding of doc Ids in vectors (apache#649)
  LUCENE-10415: FunctionScoreQuery and IndexOrDocValuesQuery delegate Weight#count. (apache#685)
dantuzi pushed a commit to SeaseLtd/lucene that referenced this pull request Mar 10, 2022
@mocobeta @dantuzi
LUCENE-10400: revise binary dictionaries' constructor in nori (apache…
7747bd0 
…#693)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uschindler uschindler uschindler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mocobeta @uschindler