LUCENE-10002: Replace test usages of TopScoreDocCollector with a corresponding collector manager #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ector manager In the effort or replacing usages of IndexSearcher#search(Query, Collector) with IndexSearcher#search(Query, CollectorManager), this commit replaces many test usages of TopScoreDocCollector with its corresponding CollectorManager created by calling TopScoreDocCollector#createSharedManager.
jpountz
approved these changes
Mar 2, 2022
jpountz
pushed a commit
that referenced
this pull request
Mar 2, 2022
…esponding collector manager (#716) In the effort or replacing usages of IndexSearcher#search(Query, Collector) with IndexSearcher#search(Query, CollectorManager), this commit replaces many test usages of TopScoreDocCollector with its corresponding CollectorManager created by calling TopScoreDocCollector#createSharedManager.
dblock
pushed a commit
to dblock/lucene
that referenced
this pull request
Mar 2, 2022
…esponding collector manager (apache#716) In the effort or replacing usages of IndexSearcher#search(Query, Collector) with IndexSearcher#search(Query, CollectorManager), this commit replaces many test usages of TopScoreDocCollector with its corresponding CollectorManager created by calling TopScoreDocCollector#createSharedManager.
dantuzi
pushed a commit
to SeaseLtd/lucene
that referenced
this pull request
Mar 10, 2022
…esponding collector manager (apache#716) In the effort or replacing usages of IndexSearcher#search(Query, Collector) with IndexSearcher#search(Query, CollectorManager), this commit replaces many test usages of TopScoreDocCollector with its corresponding CollectorManager created by calling TopScoreDocCollector#createSharedManager.
javanna
added a commit
to javanna/lucene
that referenced
this pull request
Mar 18, 2022
As part of apache#716 I moved the test to use a collector manager, but I forgot to update one of the assertions. We can't rely on totalHits being accurate when the search is executed my multiple threads and early terminated.
javanna
added a commit
to javanna/lucene
that referenced
this pull request
Mar 18, 2022
As part of apache#716 I moved the test to use a collector manager, but I forgot to update one of the assertions. We can't rely on totalHits being accurate when the search is executed my multiple threads and early terminated.
jpountz
pushed a commit
that referenced
this pull request
Mar 18, 2022
As part of #716 I moved the test to use a collector manager, but I forgot to update one of the assertions. We can't rely on totalHits being accurate when the search is executed my multiple threads and early terminated.
jpountz
pushed a commit
that referenced
this pull request
Mar 18, 2022
As part of #716 I moved the test to use a collector manager, but I forgot to update one of the assertions. We can't rely on totalHits being accurate when the search is executed my multiple threads and early terminated.
jpountz
pushed a commit
that referenced
this pull request
Mar 18, 2022
As part of #716 I moved the test to use a collector manager, but I forgot to update one of the assertions. We can't rely on totalHits being accurate when the search is executed my multiple threads and early terminated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another one of many steps towards resolution of LUCENE-10002. In the effort or replacing usages of IndexSearcher#search(Query, Collector) with IndexSearcher#search(Query, CollectorManager), this commit replaces many test usages of TopScoreDocCollector with its corresponding CollectorManager created by calling TopScoreDocCollector#createSharedManager.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.