LUCENE-10450: IndexSortSortedNumericDocValuesRangeQuery could be rewrite to MatchAllDocsQuery #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite to MatchAllDocsQuery
jpountz
approved these changes
Mar 2, 2022
jpountz
pushed a commit
that referenced
this pull request
Mar 2, 2022
…ite to MatchAllDocsQuery (#720)
dblock
pushed a commit
to dblock/lucene
that referenced
this pull request
Mar 2, 2022
…ite to MatchAllDocsQuery (apache#720)
dantuzi
pushed a commit
to SeaseLtd/lucene
that referenced
this pull request
Mar 10, 2022
…ite to MatchAllDocsQuery (apache#720)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see IndexOrDocValuesQuery as a fallbackQuery of IndexSortSortedNumericDocValuesRangeQuery in Elasticsearch, so After LUCENE-10442, we should rewrite IndexSortSortedNumericDocValuesRangeQuery to MatchAllDocsQuery if fallbackQuery could be as MatchAllDocsQuery?