LUCENE-9387: Remove CodecReader#ramBytesUsed. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes `ramBytesUsed()` from `CodecReader` and all file formats besides vectors, which is the only remaining file format that might use lots of memory in the default codec. I left `ramBytesUsed()` on the `completion` format too, which is another feature that could use lots of memory. Other components that relied on being able to compute memory usage of readers like facets' TaxonomyReader and the analyzing suggester assume that readers have a RAM usage of 0 now.
janhoy
pushed a commit
to cominvent/lucene
that referenced
this pull request
May 12, 2021
Co-authored-by: epugh@opensourceconnections.com <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes
ramBytesUsed()fromCodecReaderand all file formatsbesides vectors, which is the only remaining file format that might use lots of
memory in the default codec. I left
ramBytesUsed()on thecompletionformattoo, which is another feature that could use lots of memory.
Other components that relied on being able to compute memory usage of readers
like facets' TaxonomyReader and the analyzing suggester assume that readers have
a RAM usage of 0 now.