LUCENE-10555: avoid NumericLeafComparator#iteratorCost repeated initialization when NumericLeafComparator#setScorer is called #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjp719
changed the title
|
@jpountz Hi, can you help to review this pr? thanks |
jpountz
reviewed
May 10, 2022
lucene/core/src/java/org/apache/lucene/search/comparators/NumericComparator.java
Outdated
Show resolved
Hide resolved
* main: LUCENE-10532: remove @Slow annotation (apache#832) LUCENE-10312: Add PersianStemmer (apache#540) LUCENE-10558: Implement URL ctor to support classpath/module usage in Kuromoji and Nori dictionaries (main branch) (apache#871) LUCENE-10436: Reinstate public getdocValuesdocIdSetIterator method on DocValues (apache#869) Disable liftbot, we have our own tools LUCENE-10553: Fix WANDScorer's handling of 0 and +Infty. (apache#860) Make CONTRIBUTING.md a bit more succinct (apache#866) LUCENE-10504: KnnGraphTester to use KnnVectorQuery (apache#796) Add change line for LUCENE-9848 LUCENE-9848 Sort HNSW graph neighbors for construction (apache#862)
wjp719
changed the title
|
@jpountz Hi, I have add the change entry. please review again, thanks |
jpountz
approved these changes
May 10, 2022
jpountz
pushed a commit
that referenced
this pull request
May 10, 2022
…alization when NumericLeafComparator#setScorer is called (#864)
wjp719
added a commit
to wjp719/lucene
that referenced
this pull request
May 11, 2022
* main: Fix rare test failures in TestSortOptimization. fix bkd test logic error and doc error (apache#863) LUCENE-10555: avoid NumericLeafComparator#iteratorCost repeated initialization when NumericLeafComparator#setScorer is called (apache#864)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elasticsearch use
CancellableBulkScorerto fast cancel long time query execution by splitting one segment docs to many doc sets. When users search a topN query, for every split doc sets,TopFieldLeafCollector#setScoreris called, thenNumericLeafComparator#setScoreris called successively. As a result, for one segment,NumericLeafComparator#setScoreris called many times.Every time
NumericLeafComparator#setScoreris called, theNumericLeafComparator#iteratorCostis reset to the Scorer.cost and will increase many unnecessarypointValues#intersectcalls to get competitive docIds. This result in performance degradationThis pr checks
NumericLeafComparator#setScorerto be called only once for one segmentChecklist
Please review the following and check all that apply:
mainbranch../gradlew check.