New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LUCENE-10558: expose stream-based Kuromoji resource constructors #867
Conversation
IOSupplier<InputStream> targetMap, | ||
IOSupplier<InputStream> posDict, | ||
IOSupplier<InputStream> dict) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain why the parameter names should be changed? It's now inconsistent with other constructors (e.g. TokenInfoDictionary).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think he did this because "Resource" is a bit strange, as it is no longer classpath based.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's another day, I can no longer confirm nor deny, but Uwe's explanation makes sense to me :) If we keep this change, I'd be fine with the resource naming too, although it does have that classpath connotation?
I think the same change would be needed for Nori, I don't know the use-cases but for the completeness. |
I would not make the IOSupplier ctors available, they are internal only (IOSupplier is a class which is marked as subject to change). Because we have See #868 for an implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd go with #868
I don't think we shoudl do this, same reasons as stated on #868 These things should be loaded from jar as singletons and that's it. |
Just makes some existing constructors public, and adds javadocs