Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LUCENE-9409: Reenable TestAllFilesDetectTruncation. #896

Merged
merged 1 commit into from May 18, 2022
Merged

LUCENE-9409: Reenable TestAllFilesDetectTruncation. #896

merged 1 commit into from May 18, 2022

Conversation

jpountz
Copy link
Contributor

@jpountz jpountz commented May 17, 2022

  • Removed dependency on LineFileDocs to improve reproducibility.
  • Relaxed the expected exception type: any exception is ok.
  • Ignore rare cases when a file still appears to have a well-formed footer
    after truncation.

@jpountz
LUCENE-9409: Reenable TestAllFilesDetectTruncation.
ff7006b 
 - Removed dependency on LineFileDocs to improve reproducibility.
 - Relaxed the expected exception type: any exception is ok.
 - Ignore rare cases when a file still appears to have a well-formed footer
   after truncation.
rmuir
rmuir approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@rmuir rmuir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the new test found a bug!

@jpountz
Copy link
Contributor Author

jpountz commented May 17, 2022

The test would still pass without the new checks (another check would fail later), but I thought it was more consistent if we call checkFooter for every IndexInput we open across all file formats.

@jpountz jpountz merged commit 62189b2 into apache:main May 18, 2022
@jpountz jpountz deleted the lucene9409 branch May 18, 2022 13:52
jpountz added a commit that referenced this pull request May 18, 2022
@jpountz
LUCENE-9409: Reenable TestAllFilesDetectTruncation. (#896)
32da821 
- Removed dependency on LineFileDocs to improve reproducibility.
 - Relaxed the expected exception type: any exception is ok.
 - Ignore rare cases when a file still appears to have a well-formed footer
   after truncation.
msokolov pushed a commit to msokolov/lucene that referenced this pull request May 20, 2022
@jpountz
LUCENE-9409: Reenable TestAllFilesDetectTruncation. (apache#896)
6035ecd 
- Removed dependency on LineFileDocs to improve reproducibility.
 - Relaxed the expected exception type: any exception is ok.
 - Ignore rare cases when a file still appears to have a well-formed footer
   after truncation.
shaie pushed a commit to mdmarshmallow/lucene that referenced this pull request Jun 22, 2022
@jpountz
LUCENE-9409: Reenable TestAllFilesDetectTruncation. (apache#896)
f8aafd2 
- Removed dependency on LineFileDocs to improve reproducibility.
 - Relaxed the expected exception type: any exception is ok.
 - Ignore rare cases when a file still appears to have a well-formed footer
   after truncation.
@asfimport asfimport mentioned this pull request Jul 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmuir rmuir rmuir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpountz @rmuir