-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LUCENE-10550: Add getAllChildren functionality to facets #914
Conversation
5a1db8f
to
c92f91b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Yuti-G! Excited to see this getting implemented. I ran out of time today to look at your approach to testing, but left you some feedback on the main implementation. Thanks again!
lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java
Outdated
Show resolved
Hide resolved
lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java
Outdated
Show resolved
Hide resolved
lucene/facet/src/java/org/apache/lucene/facet/StringValueFacetCounts.java
Outdated
Show resolved
Hide resolved
lucene/facet/src/java/org/apache/lucene/facet/StringValueFacetCounts.java
Outdated
Show resolved
Hide resolved
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java
Show resolved
Hide resolved
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java
Outdated
Show resolved
Hide resolved
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FloatTaxonomyFacets.java
Show resolved
Hide resolved
...e/facet/src/java/org/apache/lucene/facet/sortedset/AbstractSortedSetDocValueFacetCounts.java
Outdated
Show resolved
Hide resolved
...e/facet/src/java/org/apache/lucene/facet/sortedset/AbstractSortedSetDocValueFacetCounts.java
Outdated
Show resolved
Hide resolved
Thanks @gsmiller for spending time reviewing my PR and leaving the great feedback! I addressed all of the comments except for the one that requires casting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Changes look good to me. Left one small comment on javadoc. Also, could you please add an entry to the CHANGES.txt
file? From what I can tell, this should be a fully backwards-compatible change, so we should be able to put it in the 9.3 section and back-port. Please let me know if you have questions on adding the CHANGES entry, or questions about back-porting. Thanks again!
...e/facet/src/java/org/apache/lucene/facet/sortedset/AbstractSortedSetDocValueFacetCounts.java
Outdated
Show resolved
Hide resolved
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java
Show resolved
Hide resolved
Thank you so much for the last check! I added more javadoc and a new entry to the CHANGES.txt. For back-porting, should I wait until this PR is merged and checkout a new branch against the latest branch_9x to cherrypick the merged commit? Thanks again! |
Exactly! Then you can open a PR with that branch against |
Merged onto |
Description
This new API returns all children for a specified path and allows users to sort in their desired criteria
Solution
Tests
Added new testing for all the overridden implementations of getAllChildren in Facets
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.