Skip to content

Commit

Permalink
BREAKING: Lucene.Net.Support.CRC32, Lucene.Net.Support.IChecksum, Luc…
Browse files Browse the repository at this point in the history
…ene.Net.Store.BufferedChecksum: Marked internal now to prevent a future breaking change, since the plan is to use HashAlgorithm as a replacement for IChecksum (see LUCENENET-637)
  • Loading branch information
NightOwl888 committed Feb 8, 2020
1 parent f396231 commit 6e88977
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
7 changes: 6 additions & 1 deletion src/Lucene.Net/Store/BufferedChecksum.cs
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,12 @@ namespace Lucene.Net.Store
/// Wraps another <see cref="IChecksum"/> with an internal buffer
/// to speed up checksum calculations.
/// </summary>
public class BufferedChecksum : IChecksum
// LUCENENET TODO: This class was public in Lucene. Marking internal, since
// a better approach would be to map this to the HashAlgorithm abstract class in .NET
// instead of using IChecksum from Java. See LUCENENET-637.
// After this conversion is done, this can be made public again. However, it is
// now internal so the conversion doesn't introduce a breaking public API change.
internal class BufferedChecksum : IChecksum
{
private readonly IChecksum @in;
private readonly byte[] buffer;
Expand Down
2 changes: 1 addition & 1 deletion src/Lucene.Net/Support/CRC32.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

namespace Lucene.Net.Support
{
public class CRC32 : IChecksum
internal class CRC32 : IChecksum
{
private static readonly UInt32[] crcTable = InitializeCRCTable();

Expand Down
2 changes: 1 addition & 1 deletion src/Lucene.Net/Support/IChecksum.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ namespace Lucene.Net.Support
/// <summary>
/// Contains conversion support elements such as classes, interfaces and static methods.
/// </summary>
public interface IChecksum
internal interface IChecksum
{
void Reset();

Expand Down

0 comments on commit 6e88977

Please sign in to comment.