Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing BufferedChecksum #248

Closed
theolivenbaum opened this issue May 5, 2020 · 2 comments
Closed

Missing BufferedChecksum #248

theolivenbaum opened this issue May 5, 2020 · 2 comments
Labels
is:duplicate This issue or pull request already exists

Comments

@theolivenbaum
Copy link
Contributor

theolivenbaum commented May 5, 2020

Hi @NightOwl888 , just noticed the latest preview version marked the BufferedChecksum class internal with this commit 6e88977

As we were using it in our code, just to understand, is this functionality something we should re-implement on our side, or will it eventually be exposed again by Lucene.Net?

@NightOwl888
Copy link
Contributor

The issue here is described in #255. The issue is that IChecksum was ported over from Java when .NET already has an abstraction for this purpose, namely, HashAlgorithm.

An attempt was made to make the conversion using Crc32.NET, an implementation of HashAlgorithm that implements CRC32. Some of the tests pass, but the CheckIndex functionality is no longer functional with this draft implementation.

Since this wasn't considered to be a primary interface and we didn't expect any users to utilize it, it has been made internal until a HashAlgorithm-derived implementation of CRC32 can be properly implemented and tested. Issue #255 is up for grabs if you would like to proceed with it to make a public implementation again.

@NightOwl888
Copy link
Contributor

Closing as duplicate of #255 (which was added to JIRA prior to this issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants