Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Test: Lucene.Net.Spatial.Prefix.SpatialOpRecursivePrefixTreeTest.TestContains() #559

Closed
NightOwl888 opened this issue Nov 23, 2021 · 0 comments · Fixed by #563
Closed
Labels
help-wanted Extra attention is needed is:bug pri:normal test-failure up-for-grabs This issue is open to be worked on by anyone

Comments

@NightOwl888
Copy link
Contributor

For information about how to help us debug tests, see #269.

This test only started failing after fixing the test framework to randomize the codecs, culture and time zone (NUnit's Randomizer was always initialized with a seed of 0, so none of these were actually random).

I have confirmed it is 100% reproducible with the following info.

Lucene.Net.Tests.Spatial - netcoreapp3.1 - x86 - macOS | Tests failed: 1, passed: 43, ignored: 0TestContains
Failed 54m ago on Mac-1637661854630
Duration0:00:00.147
Ownernot available
Date started11/23/2021, 5:14:35 PM
Date completed11/23/2021, 5:14:35 PM
Failing since38m ago
Failing since build4.8.0-ci0000002578

Should have matched I#4:ShapePair(Rect(minX=-180,maxX=118,minY=-90,maxY=90) , Rect(minX=-118,maxX=-106,minY=-43,maxY=-28)) Q:Rect(minX=-180,maxX=180,minY=-81,maxY=79)

To reproduce this test result:

Option 1:

Apply the following assembly-level attributes:

[assembly: Lucene.Net.Util.RandomSeed(0xa1686ca0b2039006L)]
[assembly: NUnit.Framework.SetCulture("pt-MO")]

Option 2:

Use the following .runsettings file:

<RunSettings>
  <TestRunParameters>
    <Parameter name="tests:seed" value="0xa1686ca0b2039006" />
    <Parameter name="tests:culture" value="pt-MO" />
  </TestRunParameters>
</RunSettings>

See the .runsettings documentation at: https://docs.microsoft.com/en-us/visualstudio/test/configure-unit-tests-by-using-a-dot-runsettings-file.
at Lucene.Net.Spatial.Prefix.SpatialOpRecursivePrefixTreeTest.fail(String label, String id, IDictionary`2 indexedShapes, IDictionary`2 indexedShapesGS, IShape queryShape) in D:\a\1\s\src\Lucene.Net.Tests.Spatial\Prefix\SpatialOpRecursivePrefixTreeTest.cs:line 389
at Lucene.Net.Spatial.Prefix.SpatialOpRecursivePrefixTreeTest.doTest(SpatialOperation operation) in D:\a\1\s\src\Lucene.Net.Tests.Spatial\Prefix\SpatialOpRecursivePrefixTreeTest.cs:line 278
at Lucene.Net.Spatial.Prefix.SpatialOpRecursivePrefixTreeTest.TestContains() in D:\a\1\s\src\Lucene.Net.Tests.Spatial\Prefix\SpatialOpRecursivePrefixTreeTest.cs:line 116

See https://dev.azure.com/shad0962/Experiments/_build/results?buildId=1662&view=ms.vss-test-web.build-test-results-tab&runId=722934&resultId=100016&paneView=debug to download the test artifacts, if necessary. Note that the build will be cleaned up after 30 days.

@NightOwl888 NightOwl888 added up-for-grabs This issue is open to be worked on by anyone help-wanted Extra attention is needed is:bug test-failure pri:normal labels Nov 23, 2021
NightOwl888 added a commit to NightOwl888/lucenenet that referenced this issue Nov 24, 2021
NightOwl888 added a commit that referenced this issue Nov 24, 2021
NightOwl888 added a commit to NightOwl888/lucenenet that referenced this issue Dec 2, 2021
…ed over patch from apache/lucene@e9906a3 (from 4.9.0) (fixes apache#559).

Contains requires a non-geo instance of SpatialContext to compare corners, otherwise it may match in cases where it isn't supposed to.
NightOwl888 added a commit to NightOwl888/lucenenet that referenced this issue Dec 2, 2021
NightOwl888 added a commit that referenced this issue Dec 3, 2021
…ed over patch from apache/lucene@e9906a3 (from 4.9.0) (fixes #559).

Contains requires a non-geo instance of SpatialContext to compare corners, otherwise it may match in cases where it isn't supposed to.
NightOwl888 added a commit that referenced this issue Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted Extra attention is needed is:bug pri:normal test-failure up-for-grabs This issue is open to be worked on by anyone
Projects
None yet
1 participant