match Lucene logic of not creating the directory #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll handle this in a few days, won't merge for now |
asfgit
pushed a commit
that referenced
this pull request
Mar 20, 2015
…irectory first Fixes #117 and closes #70 Related: https://github.com/guidotag/lucenenet/commit/6137a84724a5424cb19aee261a6415a88fd839c2 laimis@46b3b79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still discussion going on about what to do with FSDirectory's GetCanonicalPath: #70 @synhershko has assigned this to himself to investigate. While he is doing that, this PR removes the offending code so that we match Lucene's behavior in that we don't create the directory if it does not exist. The failing tests related to this, TestIndexWriter.TestNoDocs and TestMultiPhraseQuery now pass.