Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing C# 6 features #198

Closed
wants to merge 1 commit into from
Closed

Removing C# 6 features #198

wants to merge 1 commit into from

Conversation

conniey
Copy link
Contributor

@conniey conniey commented Dec 6, 2016

There are C# 6 features in use (ie. NumericConfig.cs) which will not build in Visual Studio 2013. This removes those features.

@NightOwl888 @synhershko : Alternatively, I can replace the C# 6 features. What do you think?

@NightOwl888
Copy link
Contributor

Thanks for informing - this was something that slipped in by accident. Ever since I first noticed that VS2012 can't compile these features, I have been trying to keep them out of the code base.

Is NumericConfig.cs the only culprit, or are there more?

@conniey
Copy link
Contributor Author

conniey commented Dec 6, 2016

@NightOwl888 I replaced all the C# 6 features instead, so it'll continue to work in older VS versions.

@conniey conniey changed the title Updating minimum Visual Studio version to 2015 Removing C# 6 features Dec 6, 2016
@asfgit asfgit closed this in 5a4837f Dec 6, 2016
@jeme
Copy link
Contributor

jeme commented Dec 8, 2016

FYI: Project Properties -> Build -> Advanced -> Language Version.
e.g. 4 (this will disallow the use in future VS versions as well)

I Would have gone in the other direction though and migrate up and just accept that it won't build in older versions, unless there is a build server issue somewhere?

After all the new features help keeping the code cleaner on many parts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants