Implementation of Replacement for Debug.Assert() that can be turned on/off in Release build (addresses #326) #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to Lucene.Net assembly
…allow assertions to be turned on and off in the Release build
…ng.Assert() instead of System.Diagnostics.Debug.Assert()
…rt() instead of Lucene.Net.Diagnostics.Debug.Assert()
…ssert() instead of System.Diagnostics.Debug.Assert()
…tions to be not run when asserts are disabled
…n asserts are disabled
…xed issue with reflection not finding the method due to the Func<string> parameter of Debugging.Assert()
…n always instead of AssertionException only when assert is enabled
… are enabled. (closes apache#326, see apache#313)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #326
Debugging.Assert()overloads were created to replaceDebug.Assert()so they don't get compiled out of production builds. In addition, themessageparameter is aFunc<string>so we don't have the performance impact (or errors) caused by building messages for succeeding asserts.The task was expanded to include a workflow for turning off asserts when running tests. This is primarily to verify that the release build will function with asserts disabled, but can also be used to improve CI performance by reducing the amount of testing that happens.