Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary thread safety fix for ICUTokenizer/Locking patches for AttributeSource #328

Merged
merged 9 commits into from
Aug 24, 2020
Merged

Temporary thread safety fix for ICUTokenizer/Locking patches for AttributeSource #328

merged 9 commits into from
Aug 24, 2020

Commits on Aug 24, 2020

  1. Lucene.Net.Analysis.ICU: Updated Segmentation files to Lucene 8.6.1 t… 

    …o account for the latest features of ICU
    @NightOwl888
    NightOwl888 committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    0082398 View commit details
    Browse the repository at this point in the history

  2. Lucene.Net.ICU: Reverted extra locking/cloning for ThaiTokenizer

    @NightOwl888
    NightOwl888 committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    77d6fb9 View commit details
    Browse the repository at this point in the history

  3. PERFORMANCE: Lucene.Net.Util.AttributeSource: Eliminated unnecessary … 

    …try catch and replaced ContainsKey with TryGetValue
    @NightOwl888
    NightOwl888 committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    9a91c52 View commit details
    Browse the repository at this point in the history

  4. PERFORMANCE: Lucene.Net.Util.AttributeSource::GetAttribute<T>(): Remo… 

    …ved extra lookup by using TryGetValue
    @NightOwl888
    NightOwl888 committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    c3da512 View commit details
    Browse the repository at this point in the history

  5. PERFORMANCE: Lucene.Net.Util: Streamlined DefaultAttributeFactory to … 

    …make the get/update process of creating an attribute WeakReference atomic
    @NightOwl888
    NightOwl888 committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    6ae8815 View commit details
    Browse the repository at this point in the history

  6. PERFORMANCE: Lucene.Net.Util.AttributeSource.DefaultAttributeFactory:… 

    … Use external lock for better performance and removed redundant GetOrAdd() call
    @NightOwl888
    NightOwl888 committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    3747d7c View commit details
    Browse the repository at this point in the history

  7. Lucene.Net.Tests.ICU: Added concurrency test for ThaiAnalyzer

    @NightOwl888
    NightOwl888 committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    cead5e3 View commit details
    Browse the repository at this point in the history

  8. Lucene.Net.ICU: Added locking to ThaiTokenizer to only allow a single… 

    … thread to manipulate the BreakIterator at a time. This helps, but is only a partial fix.
    @NightOwl888
    NightOwl888 committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    08018b2 View commit details
    Browse the repository at this point in the history

  9. TO REVERT: Lucene.Net.ICU: Added locking to ICUTokenizer to only allo… 

    …w a single thread to manipulate the BreakIterator at a time. This can be reverted when the BreakIterator issue is fixed.
    @NightOwl888
    NightOwl888 committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    ffc8f2a View commit details
    Browse the repository at this point in the history