Reviewed All codec tests. No real issues found. Did some cleanup. #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unneeded commented out using statements.
NightOwl888
requested changes
Feb 19, 2021
src/Lucene.Net.Tests.Codecs/SimpleText/TestSimpleTextStoredFieldsFormat.cs
Show resolved
Hide resolved
NightOwl888
approved these changes
Feb 19, 2021
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added comments and removed unneeded commented out using statements. This contribution may not look like much, but it's the result of 10 hours of work. I not only reviewed all Test Classes in Lucene.Net.Tests.Codecs namespace but also reviewed all code for the base classes they use which often lived in other namespaces. All code review was done side by side against the java implementation.