introduce buffered crc32 algorithm to calculate a checksum #436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #255, based on this commit
Few more thoughts/questions:
TestBufferedChecksum
should be renamed. I can assume (because of the existence of theLuceneNetSpecificAttribute
) that it could break some inner stuff.CRC32
is left as proof of the same test results. Probably it could be dropped and replaced with implementation from crc32.netBufferedChecksumIndexInput
is a breaking change, so I wasn't sure if it should be introduced in the scope of this PR