-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker file for postgres 9.6 and 10 #227
Conversation
orhankislal
commented
Jan 17, 2018
- install plpython support for postgres
- add dockerfile for postgres 10 centos 7
- add postgres bin dir to $PATH for both 9.6 and 10
- remove unnecessary files
- install plpython support for postgres - add dockerfile for postgres 10 centos 7 - add postgres bin dir to $PATH for both 9.6 and 10 - remove unnecessary files
Refer to this link for build results (access rights to CI server needed): |
cd build && \ | ||
cmake -G "Unix Makefiles" .. && \ | ||
make && \ | ||
make install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably keep this in the new docker files.
These are required for make doc
on the docker image. It is a convenient way of building docs for developers.
pgxnclient \ | ||
flex \ | ||
bison \ | ||
graphviz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep flex
, bison
, and graphviz
in Dockerfile_centos_7_postgres_9_6
to help developers build docs using the docker image.
### uncomment the following 'RUN apt-get' line to bake LaTex into the image | ||
### Note: if you run the following line, please tag the image as | ||
### madlib/postgres_9.6:LaTex, and don't tag it as latest | ||
# RUN apt-get install -y texlive-full |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please retain this comment too in the new docker files. texlive-full
is big to have it as part of the image, so developers can refer to this to figure out the exact command to install latex. It is required to build the design doc.
Created a new pull request (#228). Closing this one. |